Skip to content

Build CUDA benchmarks once, but run in parallel#8489

Merged
AdamGS merged 3 commits into
developfrom
adamg/unifrom-codspeed-gpu-build
Jun 18, 2026
Merged

Build CUDA benchmarks once, but run in parallel#8489
AdamGS merged 3 commits into
developfrom
adamg/unifrom-codspeed-gpu-build

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Reducing the amount of GPU machines we need to get from AWS, and save some money.
An easy follow up here is to build on a machine without a GPU, which should also save some time on startup.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a team and 0ax1 June 18, 2026 10:18
@codspeed-hq

codspeed-hq Bot commented Jun 18, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.25%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 4 regressed benchmarks
✅ 1576 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_10k_random 197.9 µs 255.8 µs -22.63%
Simulation take_10k_contiguous 218.5 µs 276.4 µs -20.94%
Simulation patched_take_10k_contiguous_patches 232.2 µs 291 µs -20.18%
Simulation patched_take_10k_random 244.2 µs 303 µs -19.41%
WallTime cuda/bitpacked_u8/unpack/3bw[100M] 352.6 µs 299.3 µs +17.8%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/unifrom-codspeed-gpu-build (9ed22a8) with develop (d020924)

Open in CodSpeed

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/unifrom-codspeed-gpu-build branch from d9b785e to d400751 Compare June 18, 2026 11:02

@0ax1 0ax1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Might be worthwhile to comment in the yml why we do this.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS enabled auto-merge (squash) June 18, 2026 16:57
@AdamGS AdamGS merged commit 98d4a6a into develop Jun 18, 2026
63 checks passed
@AdamGS AdamGS deleted the adamg/unifrom-codspeed-gpu-build branch June 18, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants